Bug 104336

Summary: Refactoring: Rename HTMLFormControlElement::required to isRequired
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, apinheiro, cfleizach, cmarcelo, dmazzoni, haraken, jdiggs, macpherson, menard, mifenton, morrita, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kent Tamura
Reported 2012-12-06 20:10:59 PST
Refactoring: Rename HTMLFormControlElement::required to isRequired
Attachments
Patch (11.57 KB, patch)
2012-12-06 20:14 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.58 KB, patch)
2012-12-06 22:13 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-12-06 20:14:57 PST
Created attachment 178143 [details] Patch
Kentaro Hara
Comment 2 2012-12-06 21:26:11 PST
Comment on attachment 178143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178143&action=review > Source/WebCore/ChangeLog:3 > + Refactoring: Rename HTMLFormControlElement::required to isRequired What's the rationale for the renaming? It sounds reasonable to keep the name consistent with IDL attribute names, even if those IDL attributes are [Reflect]. > Source/WebCore/ChangeLog:8 > + m_required should be m_isRequired, and rquired() should be Typo: rquired() > Source/WebCore/ChangeLog:10 > + attributes are are [Reflected]. Typo: are are
Kent Tamura
Comment 3 2012-12-06 21:39:35 PST
Comment on attachment 178143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178143&action=review >> Source/WebCore/ChangeLog:3 >> + Refactoring: Rename HTMLFormControlElement::required to isRequired > > What's the rationale for the renaming? It sounds reasonable to keep the name consistent with IDL attribute names, even if those IDL attributes are [Reflect]. The rationale is to conform to the coding style. required() looks like a getter function for the IDL attribute, but it's not. It's confusing.
Kentaro Hara
Comment 4 2012-12-06 21:44:21 PST
Comment on attachment 178143 [details] Patch ah, makes sense.
Kent Tamura
Comment 5 2012-12-06 22:13:48 PST
Created attachment 178161 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-12-06 23:22:09 PST
Comment on attachment 178161 [details] Patch for landing Clearing flags on attachment: 178161 Committed r136925: <http://trac.webkit.org/changeset/136925>
WebKit Review Bot
Comment 7 2012-12-06 23:22:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.