Bug 104331

Summary:

Review page is super flakey now

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Crap at bottom of page	none
Patch	none

Simon Fraser (smfr)

Reported 2012-12-06 18:15:16 PST

The review page regressed significantly recently. I've observed 1. page jumps all over the place when typing 2. some keypresses in a comment cause the comment to get committed and scroll to the top of the page 3. selection sometimes disappears after command-C to copy 4. Console spews: TypeError: 'undefined' is not a function (evaluating 'container.remove()') code-review.js:1191 Please fix.

Attachments
Crap at bottom of page (92.51 KB, image/png) 2012-12-06 18:23 PST, Simon Fraser (smfr)	no flags	Details
Patch (2.08 KB, patch) 2012-12-06 18:30 PST, Ojan Vafai	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2012-12-06 18:23:22 PST

Created attachment 178128 [details] Crap at bottom of page Why does copying add crap at the bottom of the page?

Ojan Vafai

Comment 2 2012-12-06 18:27:29 PST

(In reply to comment #0) > The review page regressed significantly recently. I've observed > 1. page jumps all over the place when typing > 2. some keypresses in a comment cause the comment to get committed and scroll to the top of the page I have no idea what recent changes could have caused this. > 3. selection sometimes disappears after command-C to copy > 4. Console spews: TypeError: 'undefined' is not a function (evaluating 'container.remove()') code-review.js:1191 Whoops. I used node.remove(), which is shipping in Chrome. I should have used $(node).remove(). Will fix this now. Hopefully that will also address whatever is causing 1/2, but I don't really see hoow 1/2 are recent regressions. Please let me know if you still see those after the fix for 3/4.

Ojan Vafai

Comment 3 2012-12-06 18:30:19 PST

Created attachment 178130 [details] Patch

Ojan Vafai

Comment 4 2012-12-06 18:31:07 PST

Committed r136916: <http://trac.webkit.org/changeset/136916>

Ojan Vafai

Comment 5 2012-12-06 18:31:50 PST

Let me know if you're still seeing problems.

Simon Fraser (smfr)

Comment 6 2012-12-06 18:33:20 PST

Seems better.

Note You need to log in before you can comment on or make changes to this bug.