Bug 104301

Summary: nrwt: remove deprecated ORWT compatibility command line flags
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, ojan, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104298, 104299    
Bug Blocks:    
Attachments:
Description Flags
Patch eric: review+, webkit.review.bot: commit-queue-

Dirk Pranke
Reported 2012-12-06 14:15:21 PST
nrwt: remove deprecated ORWT compatibility command line flags
Attachments
Patch (3.57 KB, patch)
2012-12-06 14:17 PST, Dirk Pranke 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-06 14:17:37 PST
Created attachment 178081 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-06 15:23:14 PST
I really appreciate you cleaning all this up.
WebKit Review Bot
Comment 3 2012-12-06 15:25:10 PST
Comment on attachment 178081 [details] Patch Attachment 178081 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15187046
Dirk Pranke
Comment 4 2012-12-12 11:09:30 PST
Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :).
Csaba Osztrogonác
Comment 5 2012-12-12 12:07:28 PST
(In reply to comment #4) > Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :). I removed the obsolete --no-launch-safari and --use-remote-links-to-tests from the master.cfg of build.webkit.sed.hu. Now the test command is: command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-new-test-results", "--debug-rwt-logging", "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--builder-name", WithProperties("%(buildername)s"), WithProperties("--%(configuration)s")] Is there anything else I should remove?
Dirk Pranke
Comment 6 2012-12-12 12:13:10 PST
(In reply to comment #5) > (In reply to comment #4) > > Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :). > > I removed the obsolete --no-launch-safari and --use-remote-links-to-tests > from the master.cfg of build.webkit.sed.hu. Now the test command is: > command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-new-test-results", "--debug-rwt-logging", "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--builder-name", WithProperties("%(buildername)s"), WithProperties("--%(configuration)s")] > > Is there anything else I should remove? You probably want to add --no-show-results back in to replace --no-launch-safari. Otherwise, this should be all you need.
Csaba Osztrogonác
Comment 7 2012-12-12 12:15:15 PST
yes, I noticed I missed to add --no-show-results first. But I managed to do it for the second update. :)
Dirk Pranke
Comment 8 2012-12-12 14:41:03 PST
Committed r137517: <http://trac.webkit.org/changeset/137517>
Note You need to log in before you can comment on or make changes to this bug.