Bug 104261

Summary: [Win] Crash when saving history with no items in it.
Product: WebKit Reporter: peavo
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, darin, peavo, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2012-12-06 06:57:21 PST
When calling WebHistory::saveToURL() to save history, an access violation occurs if there are no history items.
Attachments
Patch (1.14 KB, patch)
2012-12-06 07:02 PST, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2012-12-06 07:02:45 PST
Created attachment 178008 [details] Patch
Darin Adler
Comment 2 2013-01-15 15:32:29 PST
Comment on attachment 178008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178008&action=review > Source/WebKit/win/WebHistory.cpp:384 > + if (!data.get()) Should be able to write just if (!data) without the get().
WebKit Review Bot
Comment 3 2013-01-15 15:46:38 PST
Comment on attachment 178008 [details] Patch Clearing flags on attachment: 178008 Committed r139801: <http://trac.webkit.org/changeset/139801>
WebKit Review Bot
Comment 4 2013-01-15 15:46:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.