Bug 104261 - [Win] Crash when saving history with no items in it.
Summary: [Win] Crash when saving history with no items in it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 06:57 PST by peavo
Modified: 2013-01-15 15:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.14 KB, patch)
2012-12-06 07:02 PST, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2012-12-06 06:57:21 PST 
When calling WebHistory::saveToURL() to save history, an access violation occurs if there are no history items.
Comment 1 peavo 2012-12-06 07:02:45 PST 
Created attachment 178008 [details]
Patch
Comment 2 Darin Adler 2013-01-15 15:32:29 PST 
Comment on attachment 178008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178008&action=review

> Source/WebKit/win/WebHistory.cpp:384
> +    if (!data.get())

Should be able to write just if (!data) without the get().
Comment 3 WebKit Review Bot 2013-01-15 15:46:38 PST 
Comment on attachment 178008 [details]
Patch

Clearing flags on attachment: 178008

Committed r139801: <http://trac.webkit.org/changeset/139801>
Comment 4 WebKit Review Bot 2013-01-15 15:46:42 PST 
All reviewed patches have been landed.  Closing bug.