Bug 104243

Summary: [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
Product: WebKit Reporter: Xiaobo Wang <xiaobwang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, mxie, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch
rwlbuis: review+
patch - final none

Xiaobo Wang
Reported 2012-12-06 01:56:00 PST
The current implementation of TestRunner::setCustomPolicyDelegate is not completed. 1. Doesn't support originating for navigation request. 2. Doesn't support delegation of navigation response. With these update we can enable tests in http/tests/download.
Attachments
patch (21.76 KB, patch)
2012-12-06 03:10 PST, Xiaobo Wang 		rwlbuis: review+
DetailsFormatted DiffDiff
patch - final (22.52 KB, patch)
2012-12-07 01:37 PST, Xiaobo Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xiaobo Wang
Comment 1 2012-12-06 03:10:25 PST
Created attachment 177985 [details] patch
Rob Buis
Comment 2 2012-12-06 06:19:47 PST
Comment on attachment 177985 [details] patch LGTM. You could have stated what tests this fixes.
Xiaobo Wang
Comment 3 2012-12-07 01:37:04 PST
Created attachment 178183 [details] patch - final Added tests fixed in ChangeLogs.
Charles Wei
Comment 4 2012-12-07 01:40:06 PST
Comment on attachment 178183 [details] patch - final commit.
WebKit Review Bot
Comment 5 2012-12-07 02:23:02 PST
Comment on attachment 178183 [details] patch - final Clearing flags on attachment: 178183 Committed r136940: <http://trac.webkit.org/changeset/136940>
WebKit Review Bot
Comment 6 2012-12-07 02:23:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.