Bug 104241

Summary: Internals.getElementByIdInShadowRoot is nonsense now.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87815    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Shinya Kawanaka 2012-12-06 01:51:30 PST 
We have ShadowRoot.getElementById() now. We should use it instead.
Comment 1 Shinya Kawanaka 2012-12-06 01:59:43 PST 
Created attachment 177975 [details]
Patch
Comment 2 Kent Tamura 2012-12-06 02:57:49 PST 
Comment on attachment 177975 [details]
Patch

ok
Comment 3 Kent Tamura 2012-12-06 02:58:30 PST 
Comment on attachment 177975 [details]
Patch

Don't you need to remove some export symbol lists?
Comment 4 Shinya Kawanaka 2012-12-06 03:19:37 PST 
(In reply to comment #3)
> (From update of attachment 177975 [details])
> Don't you need to remove some export symbol lists?

Thanks for the catch! I should remove some.
Comment 5 Shinya Kawanaka 2012-12-06 03:26:41 PST 
Created attachment 177986 [details]
Patch for landing
Comment 6 Shinya Kawanaka 2012-12-06 03:27:08 PST 
Comment on attachment 177986 [details]
Patch for landing

Waiting for bots green.
Comment 7 WebKit Review Bot 2012-12-06 05:39:43 PST 
Comment on attachment 177986 [details]
Patch for landing

Clearing flags on attachment: 177986

Committed r136834: <http://trac.webkit.org/changeset/136834>
Comment 8 WebKit Review Bot 2012-12-06 05:39:47 PST 
All reviewed patches have been landed.  Closing bug.