Bug 104241

Summary: Internals.getElementByIdInShadowRoot is nonsense now.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87815    
Attachments:
Description Flags
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-12-06 01:51:30 PST
We have ShadowRoot.getElementById() now. We should use it instead.
Attachments
Patch (6.18 KB, patch)
2012-12-06 01:59 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.38 KB, patch)
2012-12-06 03:26 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-12-06 01:59:43 PST
Created attachment 177975 [details] Patch
Kent Tamura
Comment 2 2012-12-06 02:57:49 PST
Comment on attachment 177975 [details] Patch ok
Kent Tamura
Comment 3 2012-12-06 02:58:30 PST
Comment on attachment 177975 [details] Patch Don't you need to remove some export symbol lists?
Shinya Kawanaka
Comment 4 2012-12-06 03:19:37 PST
(In reply to comment #3) > (From update of attachment 177975 [details]) > Don't you need to remove some export symbol lists? Thanks for the catch! I should remove some.
Shinya Kawanaka
Comment 5 2012-12-06 03:26:41 PST
Created attachment 177986 [details] Patch for landing
Shinya Kawanaka
Comment 6 2012-12-06 03:27:08 PST
Comment on attachment 177986 [details] Patch for landing Waiting for bots green.
WebKit Review Bot
Comment 7 2012-12-06 05:39:43 PST
Comment on attachment 177986 [details] Patch for landing Clearing flags on attachment: 177986 Committed r136834: <http://trac.webkit.org/changeset/136834>
WebKit Review Bot
Comment 8 2012-12-06 05:39:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.