Summary: | Add win8/* to Chromium DEPS (r171376) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takashi Sakamoto <tasak> | ||||
Component: | New Bugs | Assignee: | Takashi Sakamoto <tasak> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eae, morrita, noel.gordon, robertshield, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Takashi Sakamoto
2012-12-05 23:28:14 PST
Created attachment 177952 [details]
Patch
Comment on attachment 177952 [details]
Patch
rs=me
Comment on attachment 177952 [details] Patch Clearing flags on attachment: 177952 Committed r136811: <http://trac.webkit.org/changeset/136811> All reviewed patches have been landed. Closing bug. This seems to have casued the win release bot fail, http://build.webkit.org/builders/Chromium%20Win%20Release/builds/51312 src/printing depends on src/win8, which depends on src/chrome/tools/build/win/check_sdk_patch.py. That's wrong. We need to break this dependency. Looking at win8.gyp, I would probably move the python script into win8. I'm not sure why it's in the chrome directory. http://trac.webkit.org/changeset/136939 DEPS rolled to 171707, win release build bot went green \o/ |