Bug 104228

Summary: Add win8/* to Chromium DEPS (r171376)
Product: WebKit Reporter: Takashi Sakamoto <tasak>
Component: New BugsAssignee: Takashi Sakamoto <tasak>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, morrita, noel.gordon, robertshield, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Takashi Sakamoto
Reported 2012-12-05 23:28:14 PST
Current chromium/src/printing/printing.gyp requires win8: ['OS=="win"', { 'dependencies': [ '../win8/win8.gyp:win8_util', ], So need to checkout win8/* to roll Chromium DEPS to r171376.
Attachments
Patch (1.23 KB, patch)
2012-12-05 23:36 PST, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Sakamoto
Comment 1 2012-12-05 23:36:16 PST
Created attachment 177952 [details] Patch
Hajime Morrita
Comment 2 2012-12-05 23:38:41 PST
Comment on attachment 177952 [details] Patch rs=me
Takashi Sakamoto
Comment 3 2012-12-05 23:47:42 PST
Comment on attachment 177952 [details] Patch Clearing flags on attachment: 177952 Committed r136811: <http://trac.webkit.org/changeset/136811>
Takashi Sakamoto
Comment 4 2012-12-05 23:47:46 PST
All reviewed patches have been landed. Closing bug.
Emil A Eklund
Comment 5 2012-12-06 14:00:30 PST
This seems to have casued the win release bot fail, http://build.webkit.org/builders/Chromium%20Win%20Release/builds/51312
Tony Chang
Comment 6 2012-12-06 14:22:22 PST
src/printing depends on src/win8, which depends on src/chrome/tools/build/win/check_sdk_patch.py. That's wrong. We need to break this dependency. Looking at win8.gyp, I would probably move the python script into win8. I'm not sure why it's in the chrome directory.
noel gordon
Comment 8 2012-12-07 03:50:08 PST
http://trac.webkit.org/changeset/136939 DEPS rolled to 171707, win release build bot went green \o/
Note You need to log in before you can comment on or make changes to this bug.