Bug 104201

Summary: Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebCore Misc.Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 97630    
Attachments:
Description Flags
Patch
none
Patch none

Kihong Kwon
Reported 2012-12-05 18:08:22 PST
Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent, but it is used PassRefPtr now. This makes crash if there are more than one listener.
Attachments
Patch (1.70 KB, patch)
2012-12-05 18:14 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2012-12-05 19:05 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-12-05 18:14:16 PST
Created attachment 177897 [details] Patch
Laszlo Gombos
Comment 2 2012-12-05 18:42:18 PST
Comment on attachment 177897 [details] Patch r=me. Nit: "No new tests. This just a bug fixing." does not make sense to me as bug fixes require tests.
Kihong Kwon
Comment 3 2012-12-05 19:05:35 PST
Created attachment 177909 [details] Patch
Kihong Kwon
Comment 4 2012-12-05 19:07:44 PST
(In reply to comment #2) > (From update of attachment 177897 [details]) > r=me. > > Nit: "No new tests. This just a bug fixing." does not make sense to me as bug fixes require tests. I got it, it can be tested with existing test cases. I will change statement. Thank you.
WebKit Review Bot
Comment 5 2012-12-05 19:38:47 PST
Comment on attachment 177909 [details] Patch Clearing flags on attachment: 177909 Committed r136791: <http://trac.webkit.org/changeset/136791>
WebKit Review Bot
Comment 6 2012-12-05 19:38:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.