Bug 104164

Summary: [Qt][Mac] Fix libxslt and libxml2 config tests
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch hausmann: review+, hausmann: commit-queue-

Andras Becsi
Reported 2012-12-05 13:24:51 PST
[Qt][Mac] Fix libxslt and libxml2 config tests
Attachments
Patch (3.59 KB, patch)
2012-12-05 13:27 PST, Andras Becsi 		hausmann: review+
hausmann: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2012-12-05 13:27:40 PST
Created attachment 177820 [details] Patch
Simon Hausmann
Comment 2 2012-12-06 05:27:28 PST
Comment on attachment 177820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177820&action=review r=me with a small change before landing :) > Tools/qmake/config.tests/libxslt/libxslt.pro:3 > +LIBS += -lxslt I think the LIBS line should go into the mac scope, no? At least if we're using pkg-config we should not be doing LIBS += but solely rely on what pkg-config gives us. Same in libxml2.pro
Andras Becsi
Comment 3 2012-12-06 06:03:28 PST
Committed r136837: <http://trac.webkit.org/changeset/136837>
Note You need to log in before you can comment on or make changes to this bug.