Bug 104161

Summary: Empty parse cache when receiving a low memory warning
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Oliver Hunt
Reported 2012-12-05 13:22:55 PST
Empty parse cache when receiving a low memory warning
Attachments
Patch (4.98 KB, patch)
2012-12-05 13:25 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (5.77 KB, patch)
2012-12-05 15:29 PST, Oliver Hunt 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-12-05 13:25:36 PST
Created attachment 177819 [details] Patch
Build Bot
Comment 2 2012-12-05 14:37:48 PST
Comment on attachment 177819 [details] Patch Attachment 177819 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15170218
Oliver Hunt
Comment 3 2012-12-05 15:29:10 PST
Created attachment 177844 [details] Patch
Filip Pizlo
Comment 4 2012-12-05 15:38:04 PST
Comment on attachment 177844 [details] Patch R=me. When does this get invoked?
Oliver Hunt
Comment 5 2012-12-05 15:43:55 PST
Committed r136773: <http://trac.webkit.org/changeset/136773>
Geoffrey Garen
Comment 6 2012-12-05 16:46:18 PST
Comment on attachment 177844 [details] Patch You should add a call to didAbandonObjectGraph(). How about inside discardAllCode()?
Geoffrey Garen
Comment 7 2012-12-05 23:07:56 PST
It looks like this patch only covers WebCore, and not other embedders of JavaScriptCore. I think we need a handler inside JavaScriptCore or WTF.
Note You need to log in before you can comment on or make changes to this bug.