Bug 104158 – nrwt: collect all of the information about a run into a new RunDetails class

• Component: New Bugs
• Status: RESOLVED FIXED

[Dirk Pranke]

nrwt: collect all of the information about a run into a new RunDetails class

[Dirk Pranke]

Created attachment 177815 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 177815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177815&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:59
> +class RunDetails(object):

I’m not sure if RunDetails is a descriptive name. "run" is an overloaded word and can mean a lot of things.
How about something like ManagerResults or simply LayoutTestResults?

[Ojan Vafai]

Comment on attachment 177815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177815&action=review

>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:59
>> +class RunDetails(object):
> 
> I’m not sure if RunDetails is a descriptive name. "run" is an overloaded word and can mean a lot of things.
> How about something like ManagerResults or simply LayoutTestResults?

Those are overloaded too. It's hard to think of a name that doesn't have this problem. This class not used that widely, so I'm not too worried about this.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:420
> +        if options.lint_test_files:
> +            return lint(port, options)

Really we should just move this into a different script entirely. LintTestExpectations or whatever.

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 177815 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177815&action=review
> 
> >> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:59
> >> +class RunDetails(object):
> > 
> > I’m not sure if RunDetails is a descriptive name. "run" is an overloaded word and can mean a lot of things.
> > How about something like ManagerResults or simply LayoutTestResults?
> 
> Those are overloaded too. It's hard to think of a name that doesn't have this problem. This class not used that widely, so I'm not too worried about this.
> 

I'm going to defer the name-picking until a couple patches from now, when I will rename the ResultSummary class as well, if that's okay ...

> > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:420
> > +        if options.lint_test_files:
> > +            return lint(port, options)
> 
> Really we should just move this into a different script entirely. LintTestExpectations or whatever.

Yeah, I've been tempted to do that for some time. Probably a good idea.

[Dirk Pranke]

Committed r136769: <http://trac.webkit.org/changeset/136769>