Summary: | Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | egraether | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, caseq, dglazkov, egraether, keishi, loislo, nduca, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
egraether
2012-12-05 11:30:47 PST
Created attachment 177802 [details]
Patch
Created attachment 177840 [details]
Patch
pfeldman, thanks for the feedback. I rewrote the patch to using cssStyleModel. Comment on attachment 177840 [details] Patch Attachment 177840 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15147671 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Comment on attachment 177840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177840&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:777 > + WebInspector.cssModel.getInlineStylesAsync(this.id, updateInlineVisibility); Lets keep CSS -> DOM dependency one way. I.e. toggleInlineVisibility should be in CSSStyleModel and should accept node id (or node) as a parameter. > Source/WebCore/inspector/front-end/treeoutline.js:377 > + else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code) Hide is not generic enough to be dispatched from treeoutline. You should add explicit listener in the ElementsPanel.js that does it. Created attachment 178244 [details]
Patch
(In reply to comment #5) I updated the patch: > (From update of attachment 177840 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177840&action=review > > > Source/WebCore/inspector/front-end/DOMAgent.js:777 > > + WebInspector.cssModel.getInlineStylesAsync(this.id, updateInlineVisibility); > > Lets keep CSS -> DOM dependency one way. I.e. toggleInlineVisibility should be in CSSStyleModel and should accept node id (or node) as a parameter. done > > Source/WebCore/inspector/front-end/treeoutline.js:377 > > + else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code) > > Hide is not generic enough to be dispatched from treeoutline. You should add explicit listener in the ElementsPanel.js that does it. I found a spot in ElementsTreeOutline.js that seemed to fit. Comment on attachment 178244 [details] Patch Clearing flags on attachment: 178244 Committed r136974: <http://trac.webkit.org/changeset/136974> All reviewed patches have been landed. Closing bug. |