Bug 104143

Summary: [WK2] Would like to queue messages while NetworkProcess is launching
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, beidson, cmarcelo, gyuyoung.kim, menard, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
andersca: review+, buildbot: commit-queue-
with a Windows build fix none

Alexey Proskuryakov
Reported 2012-12-05 11:07:49 PST
The code to queue messages while launching only exists in WebProcessProxy.
Attachments
proposed patch (43.26 KB, patch)
2012-12-05 11:20 PST, Alexey Proskuryakov 		andersca: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
with a Windows build fix (43.26 KB, patch)
2012-12-05 12:47 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-12-05 11:20:05 PST
Created attachment 177798 [details] proposed patch
Anders Carlsson
Comment 2 2012-12-05 11:25:20 PST
Comment on attachment 177798 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=177798&action=review > Source/WebKit2/Shared/ChildProcessProxy.cpp:128 > + if (m_connection) { Would be cleaner to just return early if m_connection is null.
Build Bot
Comment 3 2012-12-05 12:20:56 PST
Comment on attachment 177798 [details] proposed patch Attachment 177798 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15153519
WebKit Review Bot
Comment 4 2012-12-05 12:23:07 PST
Attachment 177798 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Shared/ChildProcessProxy.h:48: The parameter name "reply" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 5 2012-12-05 12:47:56 PST
Created attachment 177812 [details] with a Windows build fix I don't understand the MSVC failure. Trying to fix by using public inheritance in ChildProcessProxy.
Alexey Proskuryakov
Comment 6 2012-12-05 15:29:38 PST
Committed <http://trac.webkit.org/r136770>.
Note You need to log in before you can comment on or make changes to this bug.