Bug 104138

Summary: [Gtk] add setting to enable WebGL errors on console
Product: WebKit Reporter: arno. <a.renevier>
Component: WebKitGTKAssignee: arno. <a.renevier>
Status: RESOLVED WONTFIX    
Severity: Normal CC: mrobinson, webkit.review.bot
Priority: P2    
Version: 525.x (Safari 3.2)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107035    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
wip patch none

arno.
Reported 2012-12-05 10:39:16 PST
Hi, it would be nice to allow setting webGLErrorsToConsoleEnabled
Attachments
Patch (4.76 KB, patch)
2012-12-05 10:42 PST, arno. 		no flags
DetailsFormatted DiffDiff
wip patch (6.78 KB, patch)
2013-01-16 11:36 PST, arno. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2012-12-05 10:42:51 PST
Created attachment 177792 [details] Patch patch proposal
WebKit Review Bot
Comment 2 2012-12-05 10:47:25 PST
Attachment 177792 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/webkit/webkitwebsettings.cpp:117: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:851: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:853: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:854: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:855: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:856: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2012-12-21 04:00:25 PST
I think perhaps it's not too interesting to add new API to WebKit1 unless it allows us to make the results of more tests match those of WebKit2. We plan to deprecate WebKit1 in favor of WebKit2 at some point.
arno.
Comment 4 2013-01-16 11:08:52 PST
Comment on attachment 177792 [details] Patch Ok, I'll provide a patch for WebKit2 then
arno.
Comment 5 2013-01-16 11:36:59 PST
Created attachment 183013 [details] wip patch
Note You need to log in before you can comment on or make changes to this bug.