Bug 104126

Summary:

Stop generating call stacks inside ContentSecurityPolicy

Product:

WebKit

Reporter:

Mike West <mkwst>

Component:

WebCore Misc.

Assignee:

Mike West <mkwst>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ojan, pfeldman, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Mike West

Reported 2012-12-05 08:08:30 PST

Now that bug 100650 landed, we can stop generating calls stacks inside ContentSecurityPolicy::logToConsole. This will require piping the ScriptState down into Inspector, but also means that we can slightly simplify the external addConsoleMessage interface. I'll do my best to make this patch simpler to review than that one was. :)

Attachments
Patch (33.11 KB, patch) 2012-12-05 08:31 PST, Mike West	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mike West

Comment 1 2012-12-05 08:31:40 PST

Created attachment 177759 [details] Patch

Mike West

Comment 2 2012-12-05 11:01:27 PST

Comment on attachment 177759 [details] Patch Thanks Yury. Sorry if I'm burying you in patches these days. :)

WebKit Review Bot

Comment 3 2012-12-05 11:19:08 PST

Comment on attachment 177759 [details] Patch Clearing flags on attachment: 177759 Committed r136719: <http://trac.webkit.org/changeset/136719>

WebKit Review Bot

Comment 4 2012-12-05 11:19:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.