Bug 104120

Summary: [Qt] Fix the build if the path contains "+" character
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, hausmann, ossy, vestbo, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2012-12-05 07:20:25 PST
Debian/Ubuntu package names usually contain "+" character and now the build is broken if the path contain any plus. Patch is coming soon.
Attachments
Patch (4.25 KB, patch)
2012-12-05 07:43 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.87 KB, patch)
2012-12-06 05:28 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-12-05 07:43:07 PST
Created attachment 177746 [details] Patch
Simon Hausmann
Comment 2 2012-12-05 09:19:51 PST
Comment on attachment 177746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177746&action=review > Tools/qmake/mkspecs/features/functions.prf:29 > +defineReplace(toEscapedStringForRegexp) { > + return($$replace(1, \+, \+)) > +} I thought that there was a qmake function for that. Ah yes, can you try $$re_escape?
Csaba Osztrogonác
Comment 3 2012-12-05 09:22:15 PST
I din't know if it exists, I'm going to check and use this re_escape.
Csaba Osztrogonác
Comment 4 2012-12-06 05:28:08 PST
Created attachment 178000 [details] Patch
Tor Arne Vestbø
Comment 5 2012-12-06 05:37:11 PST
Comment on attachment 178000 [details] Patch lgtm
WebKit Review Bot
Comment 6 2012-12-06 05:56:49 PST
Comment on attachment 178000 [details] Patch Clearing flags on attachment: 178000 Committed r136836: <http://trac.webkit.org/changeset/136836>
WebKit Review Bot
Comment 7 2012-12-06 05:56:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.