Bug 104112

Summary:

Use always the order iterator from data member in RenderFlexibleBox

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

104109

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Carlos Garcia Campos 2012-12-05 04:09:57 PST

Some methods receive it as parameter and others use the data member.

Comment 1 Carlos Garcia Campos 2012-12-05 04:14:18 PST

Created attachment 177724 [details]
Patch

Comment 2 Carlos Garcia Campos 2012-12-05 04:14:52 PST

This patch applies on top of patch attached to bug #104109

Comment 3 Tony Chang 2012-12-05 12:12:26 PST

Comment on attachment 177724 [details]
Patch

We should also consider making m_orderIterator stack allocated.  We would have to adjust how we initialize it.

Comment 4 Carlos Garcia Campos 2012-12-07 01:59:03 PST

Comment on attachment 177724 [details]
Patch

Committed r136938 <http://trac.webkit.org/changeset/136938>

Comment 5 Carlos Garcia Campos 2012-12-07 05:58:16 PST

(In reply to comment #3)
> (From update of attachment 177724 [details])
> We should also consider making m_orderIterator stack allocated.  We would have to adjust how we initialize it.

Yes, and we also need to make some methods that use the iterator non-const, see:

https://bugs.webkit.org/show_bug.cgi?id=104366