Bug 104083
| Summary: | [CMake] Proper encapsulation of WebKit CMake rules | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | Hironori.Fujii, hugo.lima, rakuco, ryuan.choi |
| Priority: | P2 | Keywords: | EasyFix, GoodFirstBug |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Laszlo Gombos
It seems to me that many of the rules in the top /CMakeLists.txt should be moved to /Source/CMakeLists.txt as most of the rules in /CMakeLists.txt are only relevant for files under /Source (and not for example relevant for /Tools).
As an example /Makefile is a good example how to the the encapsulation properly. The top level /CMakeLists.txt should be really only responsible for invoking sub projects under /Source and /Tools and it should not specify details how things under /Source are built.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
This has been done already.