Bug 104071

Summary:

Web Inspector: better coverage for inspector/profiler/cpu-profiler-profiling-without-inspector.html

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2012-12-04 17:30:07 PST

inspector/profiler/cpu-profiler-profiling-without-inspector.html currently does not provide enough coverage for v8's sampling profiler, as it immediately stops profiling after starting it (this is covered by a separate, and, apparently, redundant branch of code in v8's CPU profiler). We should run test for an extended time to assure sampling profiler works.

Attachments
Patch (5.50 KB, patch) 2012-12-04 17:37 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (5.48 KB, patch) 2012-12-05 13:48 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (5.74 KB, patch) 2012-12-06 11:42 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (5.97 KB, patch) 2012-12-10 04:43 PST, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-12-04 17:37:14 PST

Created attachment 177624 [details] Patch

Pavel Feldman

Comment 2 2012-12-04 18:18:13 PST

Comment on attachment 177624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177624&action=review > LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html:78 > + const roundingThreshold = 50; // Time should be good within 50ms This will be flaky. You should test that the (actualValue > expectedValue - 50).

Andrey Kosyakov

Comment 3 2012-12-05 13:48:59 PST

Created attachment 177823 [details] Patch

WebKit Review Bot

Comment 4 2012-12-05 16:33:30 PST

Comment on attachment 177823 [details] Patch Attachment 177823 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15138847 New failing tests: inspector/profiler/cpu-profiler-profiling-without-inspector.html

Andrey Kosyakov

Comment 5 2012-12-06 11:42:10 PST

Created attachment 178046 [details] Patch

WebKit Review Bot

Comment 6 2012-12-06 13:43:17 PST

Comment on attachment 178046 [details] Patch Attachment 178046 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15170648 New failing tests: inspector/profiler/cpu-profiler-profiling-without-inspector.html

Build Bot

Comment 7 2012-12-07 01:15:12 PST

Comment on attachment 178046 [details] Patch Attachment 178046 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15188210 New failing tests: inspector/profiler/cpu-profiler-profiling-without-inspector.html

Pavel Feldman

Comment 8 2012-12-07 02:20:24 PST

Comment on attachment 178046 [details] Patch It is already flaky on the try bots.

Andrey Kosyakov

Comment 9 2012-12-10 04:43:21 PST

Created attachment 178519 [details] Patch

Andrey Kosyakov

Comment 10 2012-12-10 04:46:32 PST

(In reply to comment #8) > (From update of attachment 178046 [details]) > It is already flaky on the try bots. It's not falky, these were genuine faults unrelated to timing -- the line numbers were wrong. Sorry about that, got a wrong expectation uploaded in a hurry. I've fixed that and a side effect that caused cpu-profiler-profiling.html to fail.

Andrey Kosyakov

Comment 11 2012-12-11 01:16:55 PST

Committed r137266: <http://trac.webkit.org/changeset/137266>

Andrey Kosyakov

Comment 12 2012-12-11 02:32:28 PST

Reverted r137266 for reason: New test fails on WebKit Win7 and chromium mac Committed r137276: <http://trac.webkit.org/changeset/137276>

Brian Burg

Comment 13 2014-12-12 13:41:28 PST

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.

Note You need to log in before you can comment on or make changes to this bug.