Bug 104064

Summary: nrwt: only summarize the results one way
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103824, 104072    
Attachments:
Description Flags
Patch
none
fix handling of mapping of TEXT and IMAGE+TEXT onto FAIL/Failure none

Dirk Pranke
Reported 2012-12-04 17:05:42 PST
nrwt: only summarize the results one way
Attachments
Patch (14.47 KB, patch)
2012-12-04 17:06 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix handling of mapping of TEXT and IMAGE+TEXT onto FAIL/Failure (14.90 KB, patch)
2012-12-05 14:32 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-04 17:06:53 PST
Created attachment 177610 [details] Patch
Ojan Vafai
Comment 2 2012-12-05 14:03:56 PST
Comment on attachment 177610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177610&action=review > Tools/Scripts/webkitpy/layout_tests/views/printing.py:440 > + # Don't print anything for tests that ran as expected. > + return indentation is off.
Dirk Pranke
Comment 3 2012-12-05 14:31:24 PST
(In reply to comment #2) > (From update of attachment 177610 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177610&action=review > > > Tools/Scripts/webkitpy/layout_tests/views/printing.py:440 > > + # Don't print anything for tests that ran as expected. > > + return > > indentation is off. Yeah, I actually just fixed this prior to your review but uploaded the patch to the wrong bug :).
Dirk Pranke
Comment 4 2012-12-05 14:32:26 PST
Created attachment 177831 [details] fix handling of mapping of TEXT and IMAGE+TEXT onto FAIL/Failure
Dirk Pranke
Comment 5 2012-12-05 15:15:36 PST
Committed r136767: <http://trac.webkit.org/changeset/136767>
Note You need to log in before you can comment on or make changes to this bug.