Bug 104064 - nrwt: only summarize the results one way
Summary: nrwt: only summarize the results one way
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 103824 104072
  Show dependency treegraph
 
Reported: 2012-12-04 17:05 PST by Dirk Pranke
Modified: 2012-12-05 15:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (14.47 KB, patch)
2012-12-04 17:06 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
fix handling of mapping of TEXT and IMAGE+TEXT onto FAIL/Failure (14.90 KB, patch)
2012-12-05 14:32 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-04 17:05:42 PST
nrwt: only summarize the results one way
Comment 1 Dirk Pranke 2012-12-04 17:06:53 PST
Created attachment 177610 [details]
Patch
Comment 2 Ojan Vafai 2012-12-05 14:03:56 PST
Comment on attachment 177610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177610&action=review

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:440
> +                    # Don't print anything for tests that ran as expected.
> +                    return

indentation is off.
Comment 3 Dirk Pranke 2012-12-05 14:31:24 PST
(In reply to comment #2)
> (From update of attachment 177610 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177610&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/views/printing.py:440
> > +                    # Don't print anything for tests that ran as expected.
> > +                    return
> 
> indentation is off.

Yeah, I actually just fixed this prior to your review but uploaded the patch to the wrong bug :).
Comment 4 Dirk Pranke 2012-12-05 14:32:26 PST
Created attachment 177831 [details]
fix handling of mapping of TEXT and IMAGE+TEXT onto FAIL/Failure
Comment 5 Dirk Pranke 2012-12-05 15:15:36 PST
Committed r136767: <http://trac.webkit.org/changeset/136767>