Bug 104061

Summary: nrwt: fix total number of tests computed in the result summary
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103824    
Attachments:
Description Flags
Patch
none
Patch jochen: review+

Dirk Pranke
Reported 2012-12-04 16:40:47 PST
nrwt: fix total number of tests computed in the result summary
Attachments
Patch (2.10 KB, patch)
2012-12-04 16:43 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2012-12-05 19:15 PST, Dirk Pranke 		jochen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-04 16:43:32 PST
Created attachment 177604 [details] Patch
Dirk Pranke
Comment 2 2012-12-04 16:44:05 PST
Committed r136593: <http://trac.webkit.org/changeset/136593>
Dirk Pranke
Comment 3 2012-12-04 16:44:30 PST
re-opening to ensure that the unit test is written for this.
Dirk Pranke
Comment 4 2012-12-04 16:45:42 PST
reopening to ensure that a test gets written.
Dirk Pranke
Comment 5 2012-12-04 16:47:00 PST
should also write a test to ensure that the statistics for test run time and test total time are correct as discussed in bug 103943.
Dirk Pranke
Comment 6 2012-12-05 19:15:05 PST
Created attachment 177910 [details] Patch
jochen
Comment 7 2012-12-10 06:31:33 PST
Comment on attachment 177910 [details] Patch I ran into the same problem, and after a bit of debugging came to the same fix. I verified that your patch indeed fixes the problem, so lgtm
Dirk Pranke
Comment 8 2012-12-10 10:59:43 PST
Committed r137183: <http://trac.webkit.org/changeset/137183>
Note You need to log in before you can comment on or make changes to this bug.