Bug 104031

Summary: Rename Profiler to LegacyProfiler
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, gyuyoung.kim, mhahnenberg, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 102999    
Attachments:
Description Flags
patch for landing none

Filip Pizlo
Reported 2012-12-04 13:15:49 PST
Patch forthcoming. Already rubber stamped by Mark Hahnenberg.
Attachments
patch for landing (52.46 KB, patch)
2012-12-04 14:26 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-12-04 14:26:14 PST
Created attachment 177562 [details] patch for landing
WebKit Review Bot
Comment 2 2012-12-04 14:28:34 PST
Attachment 177562 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSProfilerPrivat..." exit_code: 1 Source/JavaScriptCore/profiler/LegacyProfiler.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/jit/JITStubs.cpp:2224: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:2232: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/profiler/LegacyProfiler.h:39: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1652: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1660: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2012-12-04 14:31:49 PST
Landed in http://trac.webkit.org/changeset/136572
Note You need to log in before you can comment on or make changes to this bug.