Bug 104028

Summary: Web Inspector: simplify reportMemoryUsage signature
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, keishi, loislo, ojan, pfeldman, pmuellr, senorblanco, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 104065    
Bug Blocks:    
Attachments:
Description Flags
Patch
vsevik: review+, buildbot: commit-queue-
Patch for landing none

Yury Semikhatsky
Reported 2012-12-04 12:37:06 PST
There are lots of places where parameters have unnecessary "const&" modifier.
Attachments
Patch (20.88 KB, patch)
2012-12-04 14:10 PST, Yury Semikhatsky 		vsevik: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (21.01 KB, patch)
2012-12-04 18:28 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-12-04 14:10:38 PST
Created attachment 177555 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-12-04 14:15:23 PST
Comment on attachment 177555 [details] Patch lgtm
Build Bot
Comment 3 2012-12-04 15:19:06 PST
Comment on attachment 177555 [details] Patch Attachment 177555 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15144209
Yury Semikhatsky
Comment 4 2012-12-04 16:57:39 PST
Committed r136597: <http://trac.webkit.org/changeset/136597>
WebKit Review Bot
Comment 5 2012-12-04 17:09:13 PST
Re-opened since this is blocked by bug 104065
Yury Semikhatsky
Comment 6 2012-12-04 18:28:31 PST
Created attachment 177638 [details] Patch for landing
Yury Semikhatsky
Comment 7 2012-12-04 18:41:31 PST
Committed r136608: <http://trac.webkit.org/changeset/136608>
Note You need to log in before you can comment on or make changes to this bug.