Bug 104019

Summary: [BlackBerry] Avoid showing FCC on empty text field in a different way
Product: WebKit Reporter: Yongxin Dai <yodai>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yongxin Dai
Reported 2012-12-04 11:14:06 PST
"Early return on empty text field" causes problem (SHA 58b422c4). Now, we avoid showing FCC on empty text field in a different way. If the text field is empty, we always notify the client with non-touch triggered change. Thus, the FCC won’t show up.
Attachments
Patch (4.91 KB, patch)
2012-12-04 20:14 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
Patch (4.91 KB, patch)
2012-12-05 07:26 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yongxin Dai
Comment 1 2012-12-04 20:14:18 PST
Created attachment 177658 [details] Patch
Rob Buis
Comment 2 2012-12-05 07:13:27 PST
Comment on attachment 177658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177658&action=review LGTM. > Source/WebKit/blackberry/ChangeLog:11 > + FineCursorContnrol is able to avoid showing FCC on empty text filed. filed -> field
Yongxin Dai
Comment 3 2012-12-05 07:26:55 PST
Created attachment 177744 [details] Patch
Rob Buis
Comment 4 2012-12-05 07:30:41 PST
Comment on attachment 177744 [details] Patch Ok.
WebKit Review Bot
Comment 5 2012-12-05 07:53:44 PST
Comment on attachment 177744 [details] Patch Clearing flags on attachment: 177744 Committed r136689: <http://trac.webkit.org/changeset/136689>
WebKit Review Bot
Comment 6 2012-12-05 07:53:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.