Bug 104010

Summary:

Remove empty directories

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, eric, galpeter, jose.lejin, loki, ossy

Priority:

Keywords:

EasyFix

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
list of empty directories	none
script to find empty dirs in an svn repo	none
Patch	none

Laszlo Gombos

Reported 2012-12-04 09:54:40 PST

These are likely left behind from git. They do not cause any harm as far as I can tell, but we have quite a few of them (and I keep stumbling in them when just browsing/reading the code). At r136399, we have about 500 directories, most of them under ./LayoutTests/platform but a fair size under Source. Attached a list of empty directories and a small script to find them.

Attachments
list of empty directories (25.34 KB, text/plain) 2012-12-04 09:55 PST, Laszlo Gombos	no flags	Details
script to find empty dirs in an svn repo (164 bytes, application/x-shellscript) 2012-12-04 09:56 PST, Laszlo Gombos	no flags	Details
Patch (27.42 KB, text/plain) 2013-03-13 21:38 PDT, Jose Lejin PJ	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2012-12-04 09:55:10 PST

Created attachment 177502 [details] list of empty directories

Laszlo Gombos

Comment 2 2012-12-04 09:56:23 PST

Created attachment 177503 [details] script to find empty dirs in an svn repo

Csaba Osztrogonác

Comment 3 2012-12-04 14:39:31 PST

Yay, good proposal. ;) My dream is making "webkit-patch land" and CQ somehow remove empty directories automatically when you removed the files in them. Unfortunately it isn't trivial, because git can't handle empty directories at all. As far as I know we can only remove orphaned empty directories manually (and regularly).

Jose Lejin PJ

Comment 4 2013-03-13 21:38:52 PDT

Created attachment 193061 [details] Patch

Jose Lejin PJ

Comment 5 2013-03-13 21:46:45 PDT

I will resubmit the patch. Some error occurred while uploading patch with Tools/Scripts/webkit-patch upload. Remove empty directories details didn't come in patch.

Laszlo Gombos

Comment 6 2013-10-09 03:43:41 PDT

Most if this was taken care by http://trac.webkit.org/changeset/148159 . Also see http://trac.webkit.org/changeset/154749 and http://trac.webkit.org/changeset/156827. Closing.

Note You need to log in before you can comment on or make changes to this bug.