Bug 104000

Summary:

[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies.

Product:

WebKit

Reporter:

Krzysztof Czech <k.czech>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apinheiro, cfleizach, dmazzoni, g.czajkowski, jdiggs, lucas.de.marchi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

104101

Attachments:

Description	Flags
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies	none
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies	none

Krzysztof Czech

Reported 2012-12-04 07:27:50 PST

Assistive Technologies should find a way to distinguish WebKit-EFL.

Attachments
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies (4.44 KB, patch) 2012-12-04 07:53 PST, Krzysztof Czech	no flags	Details Formatted Diff Diff
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies (1.40 KB, patch) 2012-12-05 01:41 PST, Krzysztof Czech	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Krzysztof Czech

Comment 1 2012-12-04 07:53:50 PST

Created attachment 177480 [details] [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies

Grzegorz Czajkowski

Comment 2 2012-12-04 08:03:14 PST

LGTM.

Dominic Mazzoni

Comment 3 2012-12-04 08:27:59 PST

Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.)

chris fleizach

Comment 4 2012-12-04 10:19:54 PST

Comment on attachment 177480 [details] [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies View in context: https://bugs.webkit.org/attachment.cgi?id=177480&action=review > Source/WebCore/ChangeLog:8 > + Introduce Webkit-EFL so that Assistive Technologies could distinguish it. ...so that Assistive Technologies "can" distinguish it.

chris fleizach

Comment 5 2012-12-04 10:20:25 PST

(In reply to comment #3) > Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.) I agree with dominic here. Once that's done, it looks ready to go.

Krzysztof Czech

Comment 6 2012-12-05 01:41:07 PST

Created attachment 177696 [details] [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies

Krzysztof Czech

Comment 7 2012-12-05 01:46:54 PST

(In reply to comment #4) > (From update of attachment 177480 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177480&action=review > > > Source/WebCore/ChangeLog:8 > > + Introduce Webkit-EFL so that Assistive Technologies could distinguish it. > > ...so that Assistive Technologies "can" distinguish it. Thank you. Done.

Krzysztof Czech

Comment 8 2012-12-05 01:47:06 PST

(In reply to comment #5) > (In reply to comment #3) > > Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.) > > I agree with dominic here. Once that's done, it looks ready to go. Done.

WebKit Review Bot

Comment 9 2012-12-05 09:57:07 PST

Comment on attachment 177696 [details] [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies Clearing flags on attachment: 177696 Committed r136710: <http://trac.webkit.org/changeset/136710>

WebKit Review Bot

Comment 10 2012-12-05 09:57:10 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.