Bug 103989

Summary:

[V8] Replace String::New("symbol") with String::NewSymbol("symbol")

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	haraken: commit-queue-

Kentaro Hara

Reported 2012-12-04 02:57:05 PST

In V8, a symbol lookup is faster than a string lookup. We should use String::NewSymbol("symbol") for symbols.

Attachments
Patch (14.89 KB, patch) 2012-12-04 02:58 PST, Kentaro Hara	haraken: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-12-04 02:58:21 PST

Kentaro Hara

Comment 2 2012-12-04 02:59:03 PST

If this patch looks OK, I'll do the rest of the replacements.

Adam Barth

Comment 3 2012-12-04 08:39:38 PST

Comment on attachment 177462 [details] Patch Ok. The only downside might be that NewSymbol is slower to create.

Kentaro Hara

Comment 4 2012-12-04 16:28:46 PST

Kentaro Hara

Comment 5 2012-12-04 16:29:34 PST

Comment on attachment 177462 [details] Patch Landed manually.

Note You need to log in before you can comment on or make changes to this bug.