Bug 103987

Summary: [V8] Remove toV8Object()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dcarney, dglazkov, eric.carlson, feature-media-reviews, japhet, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kentaro Hara
Reported 2012-12-04 02:35:17 PST
toV8Object() is used only for MessagePort and ArrayBuffer only by SerializedScriptValue. It is wasteful to generate toV8Object() for all interfaces.
Attachments
Patch (21.98 KB, patch)
2012-12-04 02:37 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (22.10 KB, patch)
2012-12-04 03:21 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (22.12 KB, patch)
2012-12-04 03:46 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-04 02:37:58 PST
Created attachment 177457 [details] Patch
Dan Carney
Comment 2 2012-12-04 03:18:52 PST
You're changing the return value in WebArrayBuffer and WebBlob when m_private is 0. It may be correct to do so, but it was never like this before.
Kentaro Hara
Comment 3 2012-12-04 03:21:34 PST
Created attachment 177463 [details] Patch
Kentaro Hara
Comment 4 2012-12-04 03:22:29 PST
(In reply to comment #2) > You're changing the return value in WebArrayBuffer and WebBlob when m_private is 0. It may be correct to do so, but it was never like this before. Good point! Fixed. (Though I guess returning v8::Null() would be a correct behavior. Either way let's fix it in a follow-up patch.)
WebKit Review Bot
Comment 5 2012-12-04 03:39:41 PST
Comment on attachment 177463 [details] Patch Attachment 177463 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15126592
Peter Beverloo (cr-android ews)
Comment 6 2012-12-04 03:43:53 PST
Comment on attachment 177463 [details] Patch Attachment 177463 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15117858
Kentaro Hara
Comment 7 2012-12-04 03:46:24 PST
Created attachment 177466 [details] Patch
WebKit Review Bot
Comment 8 2012-12-04 21:12:09 PST
Comment on attachment 177466 [details] Patch Clearing flags on attachment: 177466 Committed r136634: <http://trac.webkit.org/changeset/136634>
WebKit Review Bot
Comment 9 2012-12-04 21:12:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.