Summary: | Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jae Hyun Park <jaepark> | ||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abecsi, cmarcelo, gyuyoung.kim, menard, noam, rakuco, webkit.review.bot, zeno | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 102994 | ||||||||||||
Attachments: |
|
Description
Jae Hyun Park
2012-12-04 01:26:13 PST
Created attachment 177444 [details]
Patch
Comment on attachment 177444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177444&action=review > Source/WebKit2/Scripts/webkit2/messages.py:400 > + 'WebKit::CoordinatedLayerInfo': ['"CoordinatedLayerInfo.h"'], This is not needed Created attachment 177695 [details]
Patch
(In reply to comment #2) > (From update of attachment 177444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177444&action=review > > > Source/WebKit2/Scripts/webkit2/messages.py:400 > > + 'WebKit::CoordinatedLayerInfo': ['"CoordinatedLayerInfo.h"'], > > This is not needed Fixed. Thanks for the review! Comment on attachment 177695 [details] Patch Rejecting attachment 177695 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp.rej patching file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h Hunk #1 FAILED at 78. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15174038 Created attachment 177914 [details]
Patch
Created attachment 178111 [details]
Patch
Comment on attachment 178111 [details] Patch Clearing flags on attachment: 178111 Committed r136912: <http://trac.webkit.org/changeset/136912> All reviewed patches have been landed. Closing bug. |