Bug 103967

Summary: [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, cc-bugs, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104046    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dana Jansens
Reported 2012-12-03 20:49:41 PST
[chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
Attachments
Patch (3.26 KB, patch)
2012-12-03 20:50 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2012-12-04 14:41 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (8.00 KB, patch)
2012-12-04 14:45 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-12-03 20:50:05 PST
Created attachment 177404 [details] Patch
WebKit Review Bot
Comment 2 2012-12-03 20:53:13 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Dana Jansens
Comment 3 2012-12-03 21:08:20 PST
*** Bug 103954 has been marked as a duplicate of this bug. ***
James Robinson
Comment 4 2012-12-03 23:12:34 PST
Comment on attachment 177404 [details] Patch Look at Tools/DumpRenderTree/chromium/WebViewHost.cpp's implementation of createOutputSurface(). How will that work with this change? We need some way to hook up the compositor's output surface to something we can use in a layout tests for DRT. R- until we figure that out.
Dana Jansens
Comment 5 2012-12-04 10:22:22 PST
Huh.. DRT works fine for me.. somehow.
Dana Jansens
Comment 6 2012-12-04 14:41:55 PST
Created attachment 177568 [details] Patch
Dana Jansens
Comment 7 2012-12-04 14:45:17 PST
Created attachment 177572 [details] Patch Cleanup in WebViewHost
Dana Jansens
Comment 8 2012-12-04 14:59:50 PST
The path to landing these things are: 1. This. 2. https://codereview.chromium.org/11348371/ 3. https://bugs.webkit.org/show_bug.cgi?id=104046 4. Remove the #define USE_CC_OUTPUT_SURFACE from cc/
James Robinson
Comment 9 2012-12-05 16:32:11 PST
Comment on attachment 177572 [details] Patch Looks good, although we'll still be passing a seemingly-empty interface around in WebViewHost. We can fix that eventually...
WebKit Review Bot
Comment 10 2012-12-05 16:41:20 PST
Comment on attachment 177572 [details] Patch Clearing flags on attachment: 177572 Committed r136779: <http://trac.webkit.org/changeset/136779>
WebKit Review Bot
Comment 11 2012-12-05 16:41:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.