Bug 103933

Summary: ShadowRoot should recalcStyle for itself
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, ojan, peter+ews, philn, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Elliott Sprehn
Reported 2012-12-03 14:55:09 PST
ShadowRoot should recalcStyle for itself
Attachments
Patch (3.90 KB, patch)
2012-12-03 15:01 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (3.82 KB, patch)
2012-12-03 15:18 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (4.02 KB, patch)
2012-12-03 17:09 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.19 KB, patch)
2012-12-05 01:51 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-12-03 15:01:23 PST
Created attachment 177341 [details] Patch
WebKit Review Bot
Comment 2 2012-12-03 15:11:20 PST
Comment on attachment 177341 [details] Patch Attachment 177341 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15119506
Elliott Sprehn
Comment 3 2012-12-03 15:18:25 PST
Created attachment 177347 [details] Patch
Elliott Sprehn
Comment 4 2012-12-03 15:18:58 PST
(In reply to comment #3) > Created an attachment (id=177347) [details] > Patch My bad, ElementShadow is not a Node so you need to qualify Node::StyleChange.
Early Warning System Bot
Comment 5 2012-12-03 15:51:18 PST
Comment on attachment 177347 [details] Patch Attachment 177347 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15119529
Early Warning System Bot
Comment 6 2012-12-03 16:01:11 PST
Comment on attachment 177347 [details] Patch Attachment 177347 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15098756
Peter Beverloo (cr-android ews)
Comment 7 2012-12-03 17:00:49 PST
Comment on attachment 177347 [details] Patch Attachment 177347 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15120577
Elliott Sprehn
Comment 8 2012-12-03 17:09:33 PST
Created attachment 177377 [details] Patch Fix the build
Dimitri Glazkov (Google)
Comment 9 2012-12-03 19:48:46 PST
Comment on attachment 177377 [details] Patch Morrita-san, can you take a look?
Hajime Morrita
Comment 10 2012-12-04 17:40:03 PST
Comment on attachment 177377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177377&action=review Looks good. > Source/WebCore/dom/ShadowRoot.cpp:47 > +#include "Text.h" Then we might no longer need to include Text.h in ElementShadow.cpp
Elliott Sprehn
Comment 11 2012-12-05 01:51:52 PST
Created attachment 177700 [details] Patch for landing
Elliott Sprehn
Comment 12 2012-12-05 01:54:41 PST
(In reply to comment #10) > (From update of attachment 177377 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177377&action=review > > ... > > Source/WebCore/dom/ShadowRoot.cpp:47 > > +#include "Text.h" > > Then we might no longer need to include Text.h in ElementShadow.cpp Done. Just need a cq+ :)
WebKit Review Bot
Comment 13 2012-12-05 05:12:52 PST
Comment on attachment 177700 [details] Patch for landing Clearing flags on attachment: 177700 Committed r136675: <http://trac.webkit.org/changeset/136675>
WebKit Review Bot
Comment 14 2012-12-05 05:12:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.