Bug 103929

Summary: Disable WebKit2 api tests on Apple Windows port
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, andersca, ap, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
patch
thorton: review+
less whacky none

Roger Fong
Reported 2012-12-03 14:33:01 PST
We will be disabling WebKit2 API tests. Disabling WebKit2 API tests for Windows port.
Attachments
patch (1.59 KB, patch)
2012-12-03 14:48 PST, Roger Fong 		no flags
DetailsFormatted DiffDiff
patch (1.20 KB, patch)
2012-12-03 15:49 PST, Roger Fong 		thorton: review+
DetailsFormatted DiffDiff
less whacky (1.18 KB, text/plain)
2012-12-03 16:09 PST, Roger Fong 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-12-03 14:48:49 PST
Created attachment 177338 [details] patch
Tim Horton
Comment 2 2012-12-03 14:58:56 PST
Comment on attachment 177338 [details] patch Can we early-"next" instead of nesting the meat of the function?
Roger Fong
Comment 3 2012-12-03 15:49:49 PST
Created attachment 177358 [details] patch
Tim Horton
Comment 4 2012-12-03 15:57:06 PST
Comment on attachment 177358 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=177358&action=review > Tools/Scripts/run-api-tests:276 > + } elsif (!isAppleWinWebKit() || $suite !~ m/WebKit2*/) { > + # Disabling WebKit2 API test on Windows since we will be disabling WebKit2 on Windows. A little wacky but better, but maybe use next to make it less wacky.
Roger Fong
Comment 5 2012-12-03 16:09:17 PST
Created attachment 177363 [details] less whacky
Roger Fong
Comment 6 2012-12-03 16:53:13 PST
http://trac.webkit.org/changeset/136456
Eric Seidel (no email)
Comment 7 2013-01-04 00:53:56 PST
Comment on attachment 177363 [details] less whacky Cleared review? from attachment 177363 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.