Bug 103928

Summary: Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Elliott Sprehn
Reported 2012-12-03 14:27:37 PST
Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
Attachments
Patch (1.50 KB, patch)
2012-12-03 14:28 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2012-12-03 14:35 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-12-03 14:28:52 PST
Created attachment 177331 [details] Patch
Build Bot
Comment 2 2012-12-03 14:33:14 PST
Comment on attachment 177331 [details] Patch Attachment 177331 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15097717
Elliott Sprehn
Comment 3 2012-12-03 14:35:51 PST
Created attachment 177335 [details] Patch
WebKit Review Bot
Comment 4 2012-12-03 18:11:03 PST
Comment on attachment 177335 [details] Patch Rejecting attachment 177335 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/15121508
Elliott Sprehn
Comment 5 2012-12-03 18:12:17 PST
(In reply to comment #4) > (From update of attachment 177335 [details]) > Rejecting attachment 177335 [details] from commit-queue. > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html > Full output: http://queues.webkit.org/results/15121508 Seems super unlikely I broke the debugger... :)
Dirk Pranke
Comment 6 2012-12-04 14:44:51 PST
Comment on attachment 177335 [details] Patch Clearing flags on attachment: 177335 Committed r136577: <http://trac.webkit.org/changeset/136577>
Dirk Pranke
Comment 7 2012-12-04 14:44:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.