Summary: | [Resource Timing] Expose timing information for iframes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Simonsen <simonjam> | ||||||||
Component: | Platform | Assignee: | James Simonsen <simonjam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | japhet, pan.deng, syoichi, tonyg, webkit.review.bot, zan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 49246 | ||||||||||
Bug Blocks: | 84883 | ||||||||||
Attachments: |
|
Description
James Simonsen
2012-12-03 14:26:57 PST
Created attachment 195812 [details]
Patch
Comment on attachment 195812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195812&action=review > LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html:1 > +<!DOCTYPE html> Where are the expectations for this new test? Created attachment 195815 [details]
Patch
(In reply to comment #2) > (From update of attachment 195812 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195812&action=review > > > LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html:1 > > +<!DOCTYPE html> > > Where are the expectations for this new test? Oops. Forgot to 'git add'. Fixed now. Comment on attachment 195815 [details]
Patch
lgtm but Nate should review the CachedResourceLoader changes
Comment on attachment 195815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195815&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:535 > + if (frame()->ownerElement() && m_documentLoader->frameLoader()->stateMachine()->committingFirstRealLoad()) { > + InitiatorInfo info = { frame()->ownerElement()->localName(), monotonicallyIncreasingTime() }; > + m_initiatorMap.add(newResource.get(), info); > + } This probably needs a comment, maybe a link to the spec? Created attachment 196037 [details]
Patch for landing
(In reply to comment #6) > (From update of attachment 195815 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195815&action=review > > > Source/WebCore/loader/cache/CachedResourceLoader.cpp:535 > > + if (frame()->ownerElement() && m_documentLoader->frameLoader()->stateMachine()->committingFirstRealLoad()) { > > + InitiatorInfo info = { frame()->ownerElement()->localName(), monotonicallyIncreasingTime() }; > > + m_initiatorMap.add(newResource.get(), info); > > + } > > This probably needs a comment, maybe a link to the spec? Done. Comment on attachment 196037 [details] Patch for landing Clearing flags on attachment: 196037 Committed r147387: <http://trac.webkit.org/changeset/147387> All reviewed patches have been landed. Closing bug. After the patch landed the following test started failing persistently on Chromium bots: http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fw3c%2Fwebperf%2Fsubmission%2FGoogle%2Fresource-timing%2Fhtml%2Ftest_resource_cached.html It is also failing on the GTK port (with another test), covered in bug #113772. |