Bug 103897 – [chromium] Remove linux theme related files and switch to default

• Component: Platform
• Status: RESOLVED FIXED

[Scott Violet]

Now that Chrome has switched from using the linux theme related files to those named 'default', we should be able to safely remove the existing linux theme files.

[Scott Violet]

Created attachment 177265 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Peter Beverloo (cr-android ews)]

Comment on attachment 177265 [details]
Patch

Attachment 177265 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15086985

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 177265 [details])
> Attachment 177265 [details] did not pass cr-android-ews (chromium-android):
> Output: http://queues.webkit.org/results/15086985

Looks like RenderThemeChromiumAndroid inherits from RenderThemeChromiumLinux.

[Scott Violet]

Created attachment 177322 [details]
Patch

[Peter Beverloo (cr-android ews)]

Comment on attachment 177322 [details]
Patch

Attachment 177322 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15106641

[Scott Violet]

Created attachment 177333 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177333 [details]
Patch

Rejecting attachment 177333 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   c946dc2..4fff33e  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at 4fff33ef2c3643b9c03a8cb2127d86b4da5e5c22 but expected c946dc25a0c0757b0c8da5577f31cb3705943299
 ! c946dc2..4fff33e  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15103725

[WebKit Review Bot]

Comment on attachment 177333 [details]
Patch

Clearing flags on attachment: 177333

Committed r136460: <http://trac.webkit.org/changeset/136460>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 103958

[Takashi Sakamoto]

Would you update chromium source, webkit/support/test_webkit_platform_support.cc?

The file includes WebThemeEngine.h. The following is compile error log:

In file included from webkit/support/test_webkit_platform_support.cc:65:
./third_party/WebKit/Source/WebKit/chromium/public/platform/linux/WebThemeEngine.h:31:10: fatal error: '../../../../../Platform/chromium/public/linux/WebThemeEngine.h' file not found
#include "../../../../../Platform/chromium/public/linux/WebThemeEngine.h"

Best regards,
Takashi Sakamoto

[Scott Violet]

Created attachment 177775 [details]
Patch

[Scott Violet]

Latest patch should work now that test_webkit_platform_support.cc has been updated in the chrome side. Additionally the third patchset missed one file that is no longer needed.

[WebKit Review Bot]

Comment on attachment 177775 [details]
Patch

Clearing flags on attachment: 177775

Committed r136784: <http://trac.webkit.org/changeset/136784>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 104212

[Scott Violet]

Created attachment 178229 [details]
Patch

[Scott Violet]

Patchset 5 should be the same as 4. Hopefully it'll take this time as necessary bits on the chrome side have been updated.

[WebKit Review Bot]

Comment on attachment 178229 [details]
Patch

Attachment 178229 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15185463

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[WebKit Review Bot]

Comment on attachment 178229 [details]
Patch

Clearing flags on attachment: 178229

Committed r136979: <http://trac.webkit.org/changeset/136979>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.