Bug 103858

Summary: DFG should trigger rage conversion from double to contiguous if it sees a GetByVal on Double being used in an integer context
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch
none
the patch barraclough: review+

Filip Pizlo
Reported 2012-12-02 22:58:19 PST
Patch forthcoming. This should undo some of the regressions from typed double arrays.
Attachments
the patch (22.51 KB, patch)
2012-12-02 23:03 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (25.77 KB, patch)
2012-12-02 23:52 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (25.76 KB, patch)
2012-12-02 23:57 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-12-02 23:03:16 PST
Created attachment 177188 [details] the patch Not marking r? yet because I think I have some more tricks up my sleeve.
Filip Pizlo
Comment 2 2012-12-02 23:52:05 PST
Created attachment 177194 [details] the patch Made it even better.
WebKit Review Bot
Comment 3 2012-12-02 23:54:35 PST
Attachment 177194 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGArrayMode.h:198: The parameter name "flags" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 2012-12-02 23:57:54 PST
Created attachment 177195 [details] the patch Fix style
Filip Pizlo
Comment 5 2012-12-03 01:22:57 PST
Landed in http://trac.webkit.org/changeset/136372
Note You need to log in before you can comment on or make changes to this bug.