Bug 103820

Summary: [CMake] Enable building WebKit2-only build for the EFL port
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, mxie, paroga, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2012-12-01 14:41:38 PST
build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF" should - in theory - disable WebKit1 for the EFL port but it does not. Patch is coming.
Attachments
proposed patch (3.54 KB, patch)
2012-12-01 16:02 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-12-01 16:02:18 PST
Created attachment 177116 [details] proposed patch As a nice side benefit you can just build the EFL port with "cmake -DPORT=Efl $WEBKITSOURCEROOT". Previously you would have to issue "cmake -DPORT=Efl -DENABLE_WEBKIT=ON -DENABLE_WEBKIT2=ON $WEBKITSOURCEROOT" to get the same (default) configuration.
Ryuan Choi
Comment 2 2012-12-02 19:37:26 PST
LGTM. BTW, It makes webkit2 build as a default when we use 'cmake -DPORT=Efl'
Gyuyoung Kim
Comment 3 2012-12-02 22:56:05 PST
Comment on attachment 177116 [details] proposed patch Looks fine. It would be good to add this option to EFL wiki page as well.
WebKit Review Bot
Comment 4 2012-12-03 07:21:45 PST
Comment on attachment 177116 [details] proposed patch Clearing flags on attachment: 177116 Committed r136398: <http://trac.webkit.org/changeset/136398>
WebKit Review Bot
Comment 5 2012-12-03 07:21:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.