Bug 103775

Summary:

Remove stale check in check-for-webkit-framework-include-consistency

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, ddkilzer, joepeck, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix - Remove some more stale code	none

Joseph Pecoraro

Reported 2012-11-30 14:17:14 PST

The radar claims this was fixed a long time ago with: <http://webkit.org/b/56402> REGRESSION (WebKit2): keygen element doesn't work r81173 - <http://trac.webkit.org/changeset/81173> So we can remove the check in the build phase script.

Attachments
[PATCH] Proposed Fix (1.33 KB, patch) 2012-11-30 14:19 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix - Remove some more stale code (1.72 KB, patch) 2012-11-30 14:32 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2012-11-30 14:19:39 PST

Created attachment 177025 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 2 2012-11-30 14:32:39 PST

Created attachment 177026 [details] [PATCH] Proposed Fix - Remove some more stale code The "throw" in the unless block is already handled up above via "or throw". So drive-by remove the dead code.

David Kilzer (:ddkilzer)

Comment 3 2012-12-05 12:43:39 PST

Comment on attachment 177026 [details] [PATCH] Proposed Fix - Remove some more stale code r=me

WebKit Review Bot

Comment 4 2012-12-05 12:56:48 PST

Comment on attachment 177026 [details] [PATCH] Proposed Fix - Remove some more stale code Clearing flags on attachment: 177026 Committed r136743: <http://trac.webkit.org/changeset/136743>

WebKit Review Bot

Comment 5 2012-12-05 12:56:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.