Bug 103759

Summary: IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, arv, dglazkov, dgrogan, fishd, jamesr, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Joshua Bell
Reported 2012-11-30 11:30:20 PST
IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError
Attachments
Patch (66.96 KB, patch)
2012-11-30 11:37 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (68.82 KB, patch)
2012-12-03 09:44 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (70.21 KB, patch)
2012-12-03 10:07 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-11-30 11:37:37 PST
Created attachment 176999 [details] Patch
Joshua Bell
Comment 2 2012-11-30 11:38:36 PST
dglazkov@ - r?
Joshua Bell
Comment 3 2012-12-03 09:44:44 PST
Created attachment 177276 [details] Patch
Joshua Bell
Comment 4 2012-12-03 09:44:55 PST
Rebased. r? anyone?
WebKit Review Bot
Comment 5 2012-12-03 09:47:00 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Erik Arvidsson
Comment 6 2012-12-03 09:48:52 PST
Comment on attachment 177276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177276&action=review > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38 > + WebIDBDatabaseExceptionDataError = 1203, > + WebIDBDatabaseExceptionQuotaError = 1212, Can these just refer to the enum value instead of hard coding the value?
Joshua Bell
Comment 7 2012-12-03 09:52:34 PST
(In reply to comment #6) > (From update of attachment 177276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177276&action=review > > > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38 > > + WebIDBDatabaseExceptionDataError = 1203, > > + WebIDBDatabaseExceptionQuotaError = 1212, > > Can these just refer to the enum value instead of hard coding the value? I don't believe includes from WebKit/chromium/public to WebCore are permitted.
Joshua Bell
Comment 8 2012-12-03 09:53:42 PST
> I don't believe includes from WebKit/chromium/public to WebCore are permitted. "Wait; strike that, reverse it." ...includes from WebCore by headers in WebKit/chromium/public...
WebKit Review Bot
Comment 9 2012-12-03 09:57:14 PST
Comment on attachment 177276 [details] Patch Attachment 177276 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15098613
Joshua Bell
Comment 10 2012-12-03 10:07:29 PST
Created attachment 177280 [details] Patch
Joshua Bell
Comment 11 2012-12-03 10:07:45 PST
... and webkit_unit_tests updated, derp.
WebKit Review Bot
Comment 12 2012-12-03 10:54:57 PST
Comment on attachment 177280 [details] Patch Clearing flags on attachment: 177280 Committed r136417: <http://trac.webkit.org/changeset/136417>
WebKit Review Bot
Comment 13 2012-12-03 10:55:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.