Bug 103758

Summary: [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Peter Beverloo
Reported 2012-11-30 10:49:44 PST
[Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
Attachments
Patch (5.80 KB, patch)
2012-11-30 10:50 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (5.80 KB, patch)
2012-11-30 11:03 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-11-30 10:50:56 PST
Created attachment 176996 [details] Patch
Peter Beverloo
Comment 2 2012-11-30 10:56:05 PST
A subsequent cleanup would be to actually order methods on ChromiumAndroidDriver by visibility, similar to the public/private groups ChromiumAndroidPort has.
WebKit Review Bot
Comment 3 2012-11-30 11:01:39 PST
Attachment 176996 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:725: indentation is not a multiple of four [pep8/E111] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Peter Beverloo
Comment 4 2012-11-30 11:03:48 PST
Created attachment 176997 [details] Patch
Peter Beverloo
Comment 5 2012-11-30 11:04:50 PST
(In reply to comment #3) > If any of these errors are false positives, please file a bug against check-webkit-style. webkit-patch check-style-local was clean :/. Something is really wrong with my local checkout, I'm going to fix that on Monday.
Eric Seidel (no email)
Comment 6 2012-11-30 11:07:51 PST
Comment on attachment 176997 [details] Patch Looks reasonable.
Dirk Pranke
Comment 7 2012-11-30 12:07:23 PST
looks reasonable to me as well.
Peter Beverloo
Comment 8 2012-12-04 07:56:52 PST
Comment on attachment 176997 [details] Patch Forgot to set cq?/+. Thanks for the review guys!
WebKit Review Bot
Comment 9 2012-12-04 08:26:17 PST
Comment on attachment 176997 [details] Patch Clearing flags on attachment: 176997 Committed r136510: <http://trac.webkit.org/changeset/136510>
WebKit Review Bot
Comment 10 2012-12-04 08:26:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.