Bug 103748

Summary:

[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry

Product:

WebKit

Reporter:

otcheung

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

otcheung

Reported 2012-11-30 07:47:42 PST

Adding checks for null when checking cookie status in CookieJarBlackBerry

Attachments
Patch (2.87 KB, patch) 2012-11-30 07:50 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (2.88 KB, patch) 2012-11-30 07:57 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (3.62 KB, patch) 2012-11-30 08:33 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (1.63 KB, patch) 2012-12-02 10:42 PST, otcheung	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

otcheung

Comment 1 2012-11-30 07:50:36 PST

Created attachment 176967 [details] Patch

otcheung

Comment 2 2012-11-30 07:57:57 PST

Created attachment 176970 [details] Patch

Rob Buis

Comment 3 2012-11-30 08:08:33 PST

Comment on attachment 176970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176970&action=review > Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp:51 > + if (!(document && document->settings() && document->settings()->cookieEnabled())) Looks like you can reuse cookiesEnabled.

otcheung

Comment 4 2012-11-30 08:33:43 PST

Created attachment 176974 [details] Patch

Rob Buis

Comment 5 2012-11-30 08:49:41 PST

Comment on attachment 176974 [details] Patch LGTM.

WebKit Review Bot

Comment 6 2012-12-02 02:28:26 PST

Comment on attachment 176974 [details] Patch Clearing flags on attachment: 176974 Committed r136321: <http://trac.webkit.org/changeset/136321>

WebKit Review Bot

Comment 7 2012-12-02 02:28:29 PST

All reviewed patches have been landed. Closing bug.