Bug 103715

Summary: Rationalize and clean up DFG handling of scoped accesses
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
the patch oliver: review+

Filip Pizlo
Reported 2012-11-30 00:03:46 PST
We use GetScope with a scope count even in places where the base is known (put_to_base), and the scope count eliminates CSE opportunities for code that accesses variables at different scope depths. Also the code could just be simplified.
Attachments
work in progress (26.70 KB, patch)
2012-11-30 00:06 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (28.57 KB, patch)
2012-11-30 03:28 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-30 00:06:56 PST
Created attachment 176907 [details] work in progress Still testing it.
Filip Pizlo
Comment 2 2012-11-30 03:28:07 PST
Created attachment 176935 [details] the patch
Filip Pizlo
Comment 3 2012-11-30 13:57:27 PST
Landed in http://trac.webkit.org/changeset/136276
Note You need to log in before you can comment on or make changes to this bug.