Bug 103712

Summary:

[Mac] [WK2] Safari shows empty window and paints webpage in full-screen background

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

WebKit2

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, darin, d-r, hausmann, kadam, mitz, ossy, rniwa, zan, zarvai

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+, buildbot: commit-queue-

Jer Noble

Reported 2012-11-29 22:52:40 PST

Safari shows empty window and paints webpage in full-screen background

Attachments
Patch (2.03 KB, patch) 2012-11-29 23:03 PST, Jer Noble	darin: review+ buildbot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2012-11-29 22:53:20 PST

<rdar://problem/12690288>

Jer Noble

Comment 2 2012-11-29 23:03:10 PST

Created attachment 176903 [details] Patch

Build Bot

Comment 3 2013-01-16 06:42:23 PST

Comment on attachment 176903 [details] Patch Attachment 176903 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15912322 New failing tests: svg/custom/bug86119.html dom/xhtml/level3/core/canonicalform09.xhtml fast/loader/redirect-with-open-subframe-2.html fast/events/page-scaled-mouse-click-iframe.html fast/xsl/xslt-missing-namespace-in-xslt.xml dom/xhtml/level3/core/canonicalform08.xhtml http/tests/security/contentSecurityPolicy/xsl-img-blocked.php

Jer Noble

Comment 4 2013-02-25 15:40:58 PST

Committed r143981: <http://trac.webkit.org/changeset/143981>

Csaba Osztrogonác

Comment 5 2013-02-25 22:11:55 PST

(In reply to comment #4) > Committed r143981: <http://trac.webkit.org/changeset/143981> It made many tests crash on WK2 platforms: - Apple Mac WK2: http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20%28Tests%29/r143982%20%288244%29/results.html - EFL: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/r143983%20%284570%29/results.html - GTK: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/r143983%20%284570%29/results.html - Qt: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r143982%20%2814262%29/results.html Could you check and fix this regression?

Ryosuke Niwa

Comment 6 2013-02-25 22:15:53 PST

Comment on attachment 176903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176903&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:410 > + if (m_frame->coreFrame()->document()->documentElement()->containsFullScreenElement()) We certainly need a null pointer check for documentElement()?

Jer Noble

Comment 7 2013-02-25 22:37:51 PST

I'm looking into this.

Jer Noble

Comment 8 2013-02-25 22:50:18 PST

Filed: https://bugs.webkit.org/show_bug.cgi?id=110848

Note You need to log in before you can comment on or make changes to this bug.