Bug 103676

Summary:

Unused parameters on plugins/npapi.cpp

Product:

WebKit

Reporter:

KyungTae Kim <ktf.kim>

Component:

WebCore Misc.

Assignee:

KyungTae Kim <ktf.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

haraken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

KyungTae Kim

Reported 2012-11-29 15:18:35 PST

Because the 'instance' and 'menu' parameter are not used in NPN_PopUpContextMenu when !PLATFORM(QT) || !defined(XP_MACOSX), use UNUSED_PARAM macro to fix build warning -Wunused-parameter Source/WebCore/plugins/npapi.cpp:203:9: warning: unused parameter 'instance' [-Wunused-parameter] Source/WebCore/plugins/npapi.cpp:203:9: warning: unused parameter 'menu' [-Wunused-parameter]

Attachments
Patch (1.36 KB, patch) 2012-11-29 15:21 PST, KyungTae Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

KyungTae Kim

Comment 1 2012-11-29 15:21:35 PST

Created attachment 176832 [details] Patch

Kentaro Hara

Comment 2 2012-11-29 15:49:19 PST

Comment on attachment 176832 [details] Patch OK

WebKit Review Bot

Comment 3 2012-11-29 16:49:48 PST

Comment on attachment 176832 [details] Patch Clearing flags on attachment: 176832 Committed r136185: <http://trac.webkit.org/changeset/136185>

WebKit Review Bot

Comment 4 2012-11-29 16:49:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.