Bug 103639

Summary: [WinCairo] Release build fix.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, peavo, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2012-11-29 07:28:14 PST
The method BitmapImage::notSolidColor() is exported in WebKit2CFLite.def, but is only present when the define ASSERT_DISABLED == 0. This causes a link error in WinCairo release builds.
Attachments
Patch (3.72 KB, patch)
2012-11-29 07:40 PST, peavo 		no flags
DetailsFormatted DiffDiff
Patch (1.04 KB, patch)
2012-11-30 06:08 PST, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2012-11-29 07:32:53 PST
*** Bug 103640 has been marked as a duplicate of this bug. ***
peavo
Comment 2 2012-11-29 07:40:07 PST
Created attachment 176735 [details] Patch
Stephen White
Comment 3 2012-11-29 07:48:14 PST
Comment on attachment 176735 [details] Patch I don't understand why this is causing a build failure. The only callsite I can see is inside an ASSERT.
peavo
Comment 4 2012-11-30 06:08:53 PST
Created attachment 176955 [details] Patch
peavo
Comment 5 2012-11-30 06:12:13 PST
The symbol BitmapImage::notSolidColor() has now been removed from WebKit2.def and WebKit2CFLite.def. Adjusted the patch to avoid the ASSERT for PLATFORM(WIN). Now, both debug and release builds should link.
peavo
Comment 6 2012-12-03 07:58:45 PST
Already fixed by r136292.
Stephen White
Comment 7 2012-12-03 08:01:11 PST
Comment on attachment 176955 [details] Patch Removing r?, then.
Note You need to log in before you can comment on or make changes to this bug.