Bug 103634

Summary: [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sudarsana Nagineni (babu)
Reported 2012-11-29 06:52:48 PST
Add support for PlatformWebView::simulateRightClick() and enable WebKit2 unit test that uses it.
Attachments
Patch (2.34 KB, patch)
2012-11-29 07:14 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-11-29 07:14:24 PST
Created attachment 176726 [details] Patch
Gyuyoung Kim
Comment 2 2012-11-30 01:17:18 PST
Comment on attachment 176726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176726&action=review > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:105 > +void PlatformWebView::simulateRightClick(unsigned x, unsigned y) Don't you need to use left click as well ? In WK1, I added a button type argument to mouseClick function. void mouseClick(int x, int y, int button = 1 /*Left*/);
Sudarsana Nagineni (babu)
Comment 3 2012-11-30 01:35:05 PST
Comment on attachment 176726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176726&action=review >> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:105 >> +void PlatformWebView::simulateRightClick(unsigned x, unsigned y) > > Don't you need to use left click as well ? In WK1, I added a button type argument to mouseClick function. > > void mouseClick(int x, int y, int button = 1 /*Left*/); Left click is not required. API test expects only the right click.
WebKit Review Bot
Comment 4 2012-11-30 01:46:42 PST
Comment on attachment 176726 [details] Patch Clearing flags on attachment: 176726 Committed r136217: <http://trac.webkit.org/changeset/136217>
WebKit Review Bot
Comment 5 2012-11-30 01:46:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.