Bug 103579

Summary: Positioned replaced elements should resolve vertical margins against their containing block's logical width
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mitz, ojan.autocc, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103246    
Attachments:
Description Flags
Initial patch
none
Updated patch
none
Updating tests
none
Updating changelogs & tests
none
Converting to static html content none

Description Bear Travis 2012-11-28 17:01:13 PST 
They currently use the element's block-direction measurement of the containing block.
Comment 1 Bear Travis 2012-11-29 17:36:37 PST 
Created attachment 176861 [details]
Initial patch

First pass at a patch, using the containing block's logical width to resolve all percentage margins.
Comment 2 Bear Travis 2012-11-29 17:39:16 PST 
Created attachment 176863 [details]
Updated patch

Uploading a newer version of the patch, with changelogs and tests.
Comment 3 Bear Travis 2012-11-29 18:02:10 PST 
Created attachment 176871 [details]
Updating tests
Comment 4 Bear Travis 2012-12-04 12:42:14 PST 
Created attachment 177529 [details]
Updating changelogs & tests
Comment 5 Bear Travis 2012-12-13 17:19:36 PST 
Created attachment 179384 [details]
Converting to static html content

Creating the containers and elements with HTML markup rather than Javascript to make the test easier to read.
Comment 6 Emil A Eklund 2012-12-13 17:47:30 PST 
Comment on attachment 179384 [details]
Converting to static html content

Thanks for making the test changes I suggested. Looks good.
Comment 7 WebKit Review Bot 2012-12-13 18:14:35 PST 
Comment on attachment 179384 [details]
Converting to static html content

Clearing flags on attachment: 179384

Committed r137695: <http://trac.webkit.org/changeset/137695>
Comment 8 WebKit Review Bot 2012-12-13 18:14:39 PST 
All reviewed patches have been landed.  Closing bug.