Bug 103560

Summary: [BlackBerry] CookieJarBlackBerry will use document settings for cookiesEnabled
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gtk-ews, japhet, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

otcheung
Reported 2012-11-28 13:51:37 PST
Syncing up platform cookie settings with document settings. CookieJar will now use document settings only.
Attachments
Patch (3.76 KB, patch)
2012-11-28 14:02 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (3.80 KB, patch)
2012-11-28 14:07 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-11-28 14:02:23 PST
Created attachment 176572 [details] Patch
otcheung
Comment 2 2012-11-28 14:07:35 PST
Created attachment 176573 [details] Patch
Rob Buis
Comment 3 2012-11-28 14:08:59 PST
Comment on attachment 176573 [details] Patch LGTM.
kov's GTK+ EWS bot
Comment 4 2012-11-28 14:26:53 PST
Comment on attachment 176573 [details] Patch Attachment 176573 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15028566
WebKit Review Bot
Comment 5 2012-11-28 14:31:32 PST
Comment on attachment 176573 [details] Patch Rejecting attachment 176573 [details] from commit-queue. otcheung@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 6 2012-11-28 14:37:54 PST
Comment on attachment 176573 [details] Patch Clearing flags on attachment: 176573 Committed r136058: <http://trac.webkit.org/changeset/136058>
WebKit Review Bot
Comment 7 2012-11-28 14:37:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.